-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a just-the-tag
version scheme
#1002
Comments
Alternatively, what if E.g. The fallback implementation is to just see if the value is itself a format string. |
(FYI I'd love to PR this, just let me know which side of the fence you find yourself leaning to 😄 ) |
I need more input on the use case Currently custom dev releases are intentionally not supported to avoid tricky mess while still ensuring one valid version per commit |
(Thanks for the speedy response) Our very specific use-case is that we're mostly just interested in:
Otherwise, knowing the "distance" is nice-to-have, but ultimately doesn't help us much. The existence of the commit SHA will tell us:
|
The distance is to ensure the valid version has a non build tag part that is reasonably unique per checkout/commit, this is a help/indicator for both developers and ci This also helps if distance is suddenly Orders of magnitude different from what's sensible |
I don't follow, exactly. Wouldn't the SHA as part of the local scheme be good enough for uniqueness? Or are you suggesting that information being encoded in the non-local part is a requirement? At some point, given PEP 440, some information is going to be lost (since I don't think switching from Either way, even if it does have very good use-cases shouldn't I, the user, ultimately get to decide how I want these situations to be handled? |
(Maybe it's worth mentioning. We publish |
It's important to keep some balance between flexibility and the support/maintenance burden it triggers Letting users do everything they want is a sure fail It's important to negotiate a sane boundary The version scheme you proposed has potential fallout in a number of internal features that now would need a change/Bugfixes |
Can you help me understand? I'd love to find a middle ground here, since right now our choices are either of the "-semver" schemes, and those end up with misleading versions. |
I do agree however that support for chosen dev releases is a worthwhile feature to add |
Let's go back to the top, then. Would you support a "just-tag" version scheme? Obviously it's opt-in so users can self-select to use it. And I'd be surprised if simply using the tag broke any downstream code (seeing as how that's the behavior when distance is 0) |
That should be a good start Its also a chance to revise the way local schemes work |
Howdy! 👋
Love the tool/library. Hoping to use it for https://github.com/pantsbuild/pants versioning.
One thing is that we use
.devN
versions for the development series, so (most) of the version schemes that exist are incompatible if there's any kind of distance from the tag (the only ones that don't assert either create an illegal version like.devN.postM
or blast the dev number).Really, the distance is nice to know, but also isn't crucial to us, so meh.
The text was updated successfully, but these errors were encountered: