-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip defining wrong entry point versions on python 2.7 #5468
Comments
Lines 77 to 80 in 1335eba
i have no idea why it even is added, its always wrong |
wow, added in 37d1bf3 almost a decade back |
Indeed. This isn't right... pip's wheel metadata would be incorrect then. Seems like a packaging bug. |
This comment has been minimized.
This comment has been minimized.
@pypa/pip-committers Any suggestions here? Is this something that acts as another reason for #3164? |
The relevant code is at https://github.com/pypa/pip/blob/master/src/pip/_internal/wheel.py#L404 - this generates the versioned wrappers for pip, ignoring the entry point values. IMO, setup.py should just say
#3164 is IMO more about removing the |
Ah okay... IIUC, just updating |
Yep, I think so |
This seems more complex than just removing the two entries (see https://travis-ci.org/pypa/pip/builds/401602524) and I don't have the bandwidth to look into this currently. I'm also pushing this down the road to the next release since I don't think this would happen in time for 18.0. PRs are welcome for this though. :) |
Pushing this down the road to the next release since I don't think this'd happen in time for 18.1. If someone else does take a look, we'd probably need a PR to be merged by 30th Sept for this to make it into 18.1. |
Can this be closed now Python 2.7 support is being dropped (#6148)? |
Yep, I don't have a stake in this any more. |
Environment
Description
On installation on Python 2.7 pip creates console scripts pip, pip2, pip2.7.
However pip defines
console_scripts
pip, pip3, pip3.6 inentry_points.txt
Expected behavior
pip should define
console_scripts
entry points pip, pip2, pip2.7How to Reproduce
configure
with--with-ensurepip=install
,make
,make install
pip, pip3.6, pip3
lib/python2.7/site-packages/pip-9.0.3.dist-info/entry_points.txt
contains:[console_scripts] pip = pip:main pip3 = pip:main pip3.6 = pip:main
./python -m pip install --upgrade pip
pip, pip3.6, pip3
lib/python2.7/site-packages/pip-10.0.1.dist-info/entry_points.txt
contains:[console_scripts] pip = pip._internal:main pip3 = pip._internal:main pip3.6 = pip._internal:main
The text was updated successfully, but these errors were encountered: