Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove section about non-existing --force-keyring flag #12455

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

Darsstar
Copy link
Contributor

I must have messed up while merging/rebasing at some point...

I must have messed up while merging/rebasing at some point...
@Darsstar
Copy link
Contributor Author

I see @odormond 's PR (#12473) does the exact opposite of this PR and at the time of writing this comment has received 11 rocket emoji.

@ichard26 ichard26 added the type: docs Documentation related label Dec 26, 2024
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve and merge this as-is as I want the documentation to reflect reality. While this does mean more work for the competing PR, I sincerely doubt that pip's keyring functionality will be worked on in the forseeable future as it is outside the maintainers' collective wheelhouse.

I'll make sure to copy down the original documentation markdown so if the alternative PR is ever merged, it can be readded (and potentially/probably edited).

@ichard26 ichard26 merged commit dd6c4ad into pypa:main Dec 28, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants