Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step in packaging guide to create `setup.py' might cause confusion #838

Closed
layday opened this issue Feb 23, 2021 · 2 comments · Fixed by #856
Closed

Step in packaging guide to create `setup.py' might cause confusion #838

layday opened this issue Feb 23, 2021 · 2 comments · Fixed by #856
Labels
type: bug A confirmed bug or unintended behavior

Comments

@layday
Copy link
Member

layday commented Feb 23, 2021

The "Creating the package files" step instructs readers to create a setup.py, which remains empty, leading to build failures:

The guide later mentions that, "If you include [setup.py], you must have a call to setup() in it", but this appears to be easily overlooked.

@webknjaz webknjaz added the type: bug A confirmed bug or unintended behavior label Feb 23, 2021
@Nines9S
Copy link

Nines9S commented Feb 24, 2021

Was scratching my head for ages wondering what I was doing wrong. Looks like I skimmed over that line too, mostly my fault, but it's very easily missed for sure. Finally got it working thanks to you!

@webknjaz
Copy link
Member

webknjaz commented Feb 24, 2021

Would turning it into an IMPORTANT admonition help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants