Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --xbuildenv-path flag and PYODIDE_XBUILDENV_PATH environment variable with pyodide build #114

Open
agriyakhetarpal opened this issue Mar 3, 2025 · 4 comments

Comments

@agriyakhetarpal
Copy link
Member

(Related to #72), and as stated in the issue title. I think we should allow this, as pyodide build at the moment downloads multiple cross-build environments (in whichever folder the command is run from, rather than using the existing one). If pyodide build can know where to look, we can specify that and not use excess bandwidth.

My question is, should we call it --xbuildenv-path/PYODIDE_XBUILDENV_PATH or --xbuildenv-dir/PYODIDE_XBUILDENV_DIR, i.e., path vs dir?

@ryanking13
Copy link
Member

ryanking13 commented Mar 4, 2025

Sounds like a good idea to me.

My question is, should we call it --xbuildenv-path/PYODIDE_XBUILDENV_PATH or --xbuildenv-dir/PYODIDE_XBUILDENV_DIR, i.e., path vs dir?

Not a strong preference, but I would choose PYODIDE_XBUILDENV_PATH which is similar to PYTHONPATH and NODE_PATH.

@hoodmane
Copy link
Member

hoodmane commented Mar 4, 2025

Can we by default put it in xdg_cache_dir/ pyodide_xbuildenvs?

@agriyakhetarpal
Copy link
Member Author

Yes, that would be fine. This option would be in conjunction with that – so that we can place it in a cache dir, but also allow placing it elsewhere if specified.

@ryanking13
Copy link
Member

so that we can place it in a cache dir

+1. It would be useful to specify the xbuildenv path so people can cache it in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants