Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential typo in CLV Quickstart documentation #609

Closed
gcarnelos opened this issue Apr 3, 2024 · 4 comments
Closed

Potential typo in CLV Quickstart documentation #609

gcarnelos opened this issue Apr 3, 2024 · 4 comments
Assignees
Labels
CLV docs Improvements or additions to documentation

Comments

@gcarnelos
Copy link

This issue reports a potential inconsistency in the CLV Quickstart documentation, specifically within the "Estimating CLV" section.

The text currently reads:

  • "According to our models, customer 6 has a much higher expected CLV."

There might be a typo in the customer reference. Here are two possibilities for a more accurate representation:

  1. "According to our models, customer 5 has a much higher expected CLV."
  2. "According to our models, the 6th customer has a much higher expected CLV."

https://www.pymc-marketing.io/en/stable/notebooks/clv/clv_quickstart.html#estimating-customer-lifetime-value-using-the-gamma-gamma-model

pymc-marketing-clv_quickstart

@twiecki
Copy link
Contributor

twiecki commented Apr 3, 2024

That's confusing indeed. Maybe clearest would be "According to our models, customer[5] has a much higher expected CLV." Want to do a PR?

@ColtAllen
Copy link
Collaborator

I'm making some changes to the Quickstart in #601, and went ahead and added the fix for this.

@juanitorduz
Copy link
Collaborator

@ColtAllen can we close this one after we merged the PR?

@ColtAllen ColtAllen self-assigned this Apr 15, 2024
@ColtAllen ColtAllen added docs Improvements or additions to documentation CLV labels Apr 15, 2024
@ColtAllen
Copy link
Collaborator

Whoops, forgot this was still open. Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLV docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants