We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example:
import pandas as pd from pymc_marketing.mmm import DelayedSaturatedMMM df = pd.read_csv("datasets/mmm_example.csv", parse_dates=["date_week"]) mmm = DelayedSaturatedMMM( date_column="date_week", channel_columns=["x1", "x2"], adstock_max_lag=12, ) y = df.pop("y") mmm.sample_prior_predictive(df, extend_idata=True) # mmm.idata is completely replaced in the fit method mmm.fit(df, y)
That replacement seems to happen here: https://github.com/pymc-labs/pymc-marketing/blob/main/pymc_marketing/model_builder.py#L477
The text was updated successfully, but these errors were encountered:
I started fixing this in #414 but didn't take it to the finish line yet
Sorry, something went wrong.
Sounds good. Sorry to reraise
@ricardoV94 Does the join kwarg address this?
I think we are still overriding any old idata when we call fit, even in #482
fit
No branches or pull requests
Example:
That replacement seems to happen here: https://github.com/pymc-labs/pymc-marketing/blob/main/pymc_marketing/model_builder.py#L477
The text was updated successfully, but these errors were encountered: