-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pytorch implementation of Blockwise #988
Conversation
18f26a3
to
4f475c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start. Can we split Cholesky and Solve into a separate PR from Blockwise though? They are conceptually distinct
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #988 +/- ##
=======================================
Coverage 82.09% 82.10%
=======================================
Files 182 183 +1
Lines 47901 47924 +23
Branches 8631 8632 +1
=======================================
+ Hits 39325 39348 +23
Misses 6410 6410
Partials 2166 2166
|
batched_dims = op.batch_ndim(node) | ||
core_node = op._create_dummy_core_node(node.inputs) | ||
core_fgraph = FunctionGraph(inputs=core_node.inputs, outputs=core_node.outputs) | ||
inner_func = pytorch_funcify(core_fgraph, squeeze_output=len(node.outputs) == 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
squeeze_output always works no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, not sure what you meant with your own comment.
d4abe22
to
8286e1b
Compare
Can you squash the commits so this PR has two commits only: 1) Blockwise pytorch and 2) increasing the tolerance of the flaky pre-existing test. |
b3998a2
to
cb7dbdb
Compare
Thanks @Ch0ronomato ! |
Description
Adds the blockwise operator for torch (using torch.vmap), and adds a test.
Related Issue
Checklist
Type of change