-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding rewrites involving kronecker product #975
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
- Coverage 81.75% 81.75% -0.01%
==========================================
Files 183 183
Lines 47753 47763 +10
Branches 11617 11619 +2
==========================================
+ Hits 39042 39050 +8
- Misses 6520 6523 +3
+ Partials 2191 2190 -1
|
jessegrabowski
requested changes
Aug 18, 2024
jessegrabowski
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo then looks good to me
748a32c
to
7df205b
Compare
7df205b
to
329353d
Compare
Ch0ronomato
pushed a commit
to Ch0ronomato/pytensor
that referenced
this pull request
Nov 2, 2024
* Added rewrite for diag of kronecker product * Added rewrite for slogdet; added docstrings for rewrites * fixed typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the following rewrites :
Related Issue
Checklist
Type of change