-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix solve_triangular output when overwrite_b=True #1235
Fix solve_triangular output when overwrite_b=True #1235
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
- Coverage 81.99% 81.99% -0.01%
==========================================
Files 188 188
Lines 48566 48567 +1
Branches 8677 8677
==========================================
Hits 39823 39823
- Misses 6580 6581 +1
Partials 2163 2163
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions and a small suggestion
3f23a5d
to
16d09b9
Compare
* Fix bug in solve_triangular when `overwrite_b = True` * Add regression test
Description
Issue #1233 found a bug in the numba mode of
solve_triangular
. Basically, we can't get around copying the incoming matrices if they're not already F-contiguous. Also adds a regression test for this bug.Related Issue
solve_triangular
returns wrong results whenoverwrite_b=True
#1233Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1235.org.readthedocs.build/en/1235/