Fix Blockwise and RandomVariable in Numba with repeated arguments #1222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement Blockwise and RandomVariables in numba we use an
OpWithCoreShape
OpFromGraph subclass, that extends the original node with a core_shape input. This approach would fail whenever the original node had repeated inputs, as OpFromGraph raises by default when that's the case.For now I think simply allowing OpFromGraph to ignore those disconnected inputs should work fine. We can revisit later and use a
node.clone_with_new_inputs
or whatever is called to mask the fact the inputs are identical. I have a 90% confidence this won't be needed so I'm trying the simple approach until reality proves it wrong.📚 Documentation preview 📚: https://pytensor--1222.org.readthedocs.build/en/1222/