Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute pushforward (Rop) via double application of pullback (Lop) and fix Scan and Max gradient bugs #1207

Merged
merged 5 commits into from
Feb 17, 2025

Compute pushforward via double application of pullback

4136161
Select commit
Loading
Failed to load commit list.
Merged

Compute pushforward (Rop) via double application of pullback (Lop) and fix Scan and Max gradient bugs #1207

Compute pushforward via double application of pullback
4136161
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 14, 2025 in 0s

82.28% (+0.03%) compared to 2aecb95

View this Pull Request on Codecov

82.28% (+0.03%) compared to 2aecb95

Details

Codecov Report

Attention: Patch coverage is 85.07463% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.28%. Comparing base (2aecb95) to head (4136161).

Files with missing lines Patch % Lines
pytensor/tensor/math.py 46.15% 4 Missing and 3 partials ⚠️
pytensor/gradient.py 90.90% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
+ Coverage   82.25%   82.28%   +0.03%     
==========================================
  Files         186      186              
  Lines       47981    47987       +6     
  Branches     8630     8629       -1     
==========================================
+ Hits        39465    39486      +21     
+ Misses       6356     6347       -9     
+ Partials     2160     2154       -6     
Files with missing lines Coverage Δ
pytensor/compile/builders.py 88.66% <100.00%> (ø)
pytensor/scan/op.py 84.62% <100.00%> (-0.08%) ⬇️
pytensor/gradient.py 78.55% <90.90%> (+0.92%) ⬆️
pytensor/tensor/math.py 92.00% <46.15%> (+0.12%) ⬆️

... and 2 files with indirect coverage changes