-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not require explicit RNG in verify_grad
#1093
Conversation
tests/test_gradient.py
Outdated
@@ -602,6 +603,10 @@ def test_grad_constant(self): | |||
+ str(g_one) | |||
) | |||
|
|||
def test_verify_grad_no_rng(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for the test, the changes in the code are okay by themselves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve removed the test as suggested. Let me know if there’s anything else to address!
959a499
to
00c99f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1093 +/- ##
==========================================
+ Coverage 82.11% 82.12% +0.01%
==========================================
Files 183 183
Lines 47959 47978 +19
Branches 8635 8642 +7
==========================================
+ Hits 39381 39403 +22
+ Misses 6411 6408 -3
Partials 2167 2167
|
The pull request is ready for merge:
Let me know if there’s anything else I should address! |
Thanks again. Hope you don't mind me asking, is this a robot message? |
Haha, no not a robot, just filtered my thought with chat-gpt. This is my first PR in pymc-dev, will try to contribute more and continuously learning about pymc. |
verify_grad
Ensures that verify_grad can handle cases where an RNG is not explicitly provided
Description
Ensures that verify_grad can handle cases where an RNG is not explicitly provided, improving the function's usability and robustness. Added a new test case, test_verify_grad_no_rng, to verify that the verify_grad function works correctly without requiring an explicit RNG (random number generator) argument.
Related Issue
rng
inverify_grad
#1089Checklist
Type of change