Implement unconditional constant_folding rewrite #1068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing constant_folding makes use of
Op.do_constant_folding
to decide whether to apply itself or not, even when all inputs are constant. This is a hackish way of trying to not perform constant_folding in cases where it may lead to a sub-optimal graph (basically requiring extra copies). It is also used for rewrites to have a chance to apply themselves.This PR adds a constant_folding helper that does not follow this logic. It is not registered in the database. It's meant for advanced users / libraries to force constant_folding whenever it it is actually possible to.
📚 Documentation preview 📚: https://pytensor--1068.org.readthedocs.build/en/1068/