Raise NotImplementedError for boolean scalar indexing #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
scalar_boolean_raise
branch
from
87ea961 to
eab0019
Compare
This is a special-edge case that behaves differently than other boolean indexing. It adds a new dimension (either empty or with one entry). The logic in `make_node` and `infer_shape` don't handle this.
ricardoV94
force-pushed
the
scalar_boolean_raise
branch
from
eab0019 to
b08fb2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a special-edge case that behaves differently than other boolean indexing. It adds a new dimension (either empty or with one entry). The logic in
make_nodeandinfer_shapedon't handle this.Small cleanup around #442. I suspect the extra logic needed in the Op (and rewrites) to accommodate this special rule aren't justified or needed (since nobody requested it until now). If someone wants to work on it, they can of course!
The PR simply raises an informative error instead of failing cryptically like before.
📚 Documentation preview 📚: https://pytensor--1063.org.readthedocs.build/en/1063/