-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slogdet returns naive expression and is optimized later #1041
Slogdet returns naive expression and is optimized later #1041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a specialization rewrite that introduces slogdet as a replacement for log(abs(det(x))) and its sign.
I guess we can also do it without the abs.
This should be before we remove useless Blockwise.
6b46ffd
to
968dd7c
Compare
164f094
to
816cc77
Compare
906fbb0
to
8f6badf
Compare
@tanish1729 changes are shaping up nicely. I think one more round and we're there |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
==========================================
+ Coverage 82.11% 82.12% +0.01%
==========================================
Files 183 183
Lines 47959 47978 +19
Branches 8635 8642 +7
==========================================
+ Hits 39381 39403 +22
+ Misses 6411 6408 -3
Partials 2167 2167
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small details in the docstring rest looks great
Description
Changing slogdet so that we are able to use the rewrites made for Det
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1041.org.readthedocs.build/en/1041/