Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct usage of file context in profiling outputs #1011

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

AuguB
Copy link
Contributor

@AuguB AuguB commented Oct 3, 2024

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94 ricardoV94 added the bug Something isn't working label Oct 3, 2024
@ricardoV94 ricardoV94 changed the title Correct usage of file context in profile.py Correct usage of file context in profile Oct 3, 2024
@ricardoV94 ricardoV94 changed the title Correct usage of file context in profile Correct usage of file context in profiling outputs Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.74%. Comparing base (8a6e407) to head (89924d5).
Report is 115 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/compile/profiling.py 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1011   +/-   ##
=======================================
  Coverage   81.74%   81.74%           
=======================================
  Files         183      183           
  Lines       47733    47740    +7     
  Branches    11616    11616           
=======================================
+ Hits        39020    39027    +7     
- Misses       6518     6520    +2     
+ Partials     2195     2193    -2     
Files with missing lines Coverage Δ
pytensor/compile/profiling.py 76.15% <0.00%> (ø)

... and 4 files with indirect coverage changes

@ricardoV94 ricardoV94 merged commit b17de1d into pymc-devs:main Oct 3, 2024
59 of 60 checks passed
@ricardoV94
Copy link
Member

Thanks @AuguB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: File context not properly used in profiling._atexit_print_fn
2 participants