Fix copying of shared variables in fgraph_from_model
#7153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
fgraph_from_model
ricardoV94
force-pushed
the
fix_shared_vars_fgraph_from_model
branch
from
6535360 to
bdc55af
Compare
ricardoV94
force-pushed
the
fix_shared_vars_fgraph_from_model
branch
from
bdc55af to
52b6106
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7153 +/- ##
==========================================
+ Coverage 90.41% 92.36% +1.94%
==========================================
Files 101 101
Lines 16930 16929 -1
==========================================
+ Hits 15308 15636 +328
+ Misses 1622 1293 -329
|
AlexAndorra
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Looks all good, thanks @ricardoV94 . Really interesting to read this code, helps to understand pytensor a bit more.
I'll test it on my usecase now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7105
Also removes use of deprecated ScalarSharedVariable class pymc-devs/pytensor#629
📚 Documentation preview 📚: https://pymc--7153.org.readthedocs.build/en/7153/