Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures in lates one_mode branch #17

Closed
JNmpi opened this issue Aug 2, 2022 · 3 comments
Closed

Failures in lates one_mode branch #17

JNmpi opened this issue Aug 2, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@JNmpi
Copy link
Contributor

JNmpi commented Aug 2, 2022

I really like the new double click feature. It makes the gui much more intuitive. However, I realized two bugs:

  • When selecting and deselecting a node I cannot select it again. I first have to select another node. This is rather unintuitiv.

  • When selecting the ForEach node and double clicking on the canvas nothing happens. I guess the color definition is missing. At least this is the error I get when I try to load my example workflow.

@JNmpi JNmpi added the bug Something isn't working label Aug 2, 2022
@liamhuber liamhuber mentioned this issue Aug 2, 2022
@liamhuber
Copy link
Member

  • When selecting and deselecting a node I cannot select it again. I first have to select another node. This is rather unintuitiv.

@JNmpi, unfortunately I can't duplicate this on my machine. I agree the described behaviour is bad, but we might need to look at it next time we're on Zoom together so we can track down where it comes from.

-When selecting the ForEach node and double clicking on the canvas nothing happens. I guess the color definition is missing. At least this is the error I get when I try to load my example workflow.

Yep, your guess was spot-on. Fixed in #19.

@liamhuber liamhuber reopened this Aug 2, 2022
@liamhuber
Copy link
Member

  • When selecting and deselecting a node I cannot select it again. I first have to select another node. This is rather unintuitiv.

Nevermind, I can get this to happen. It occurs only when clicking on the body of the already selected node. IMO this shouldn't even be deselecting it -- it violates the spec draft in CanvasObject.__doc__. Shouldn't be hard to fix.

@liamhuber
Copy link
Member

  • When selecting and deselecting a node I cannot select it again. I first have to select another node. This is rather unintuitiv.

Nevermind, I can get this to happen. It occurs only when clicking on the body of the already selected node. IMO this shouldn't even be deselecting it -- it violates the spec draft in CanvasObject.__doc__. Shouldn't be hard to fix.

Fixed in #20 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants