Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outputs on update() failure #135

Closed
liamhuber opened this issue Nov 24, 2022 · 1 comment
Closed

Update outputs on update() failure #135

liamhuber opened this issue Nov 24, 2022 · 1 comment
Assignees
Labels
feature request request partner of "enhancement"

Comments

@liamhuber
Copy link
Member

When the node update() method fails, this gets passed to the log ok, but the output values simply don't get updated. From a functional paradigm we want input and output to stay linked, so these should be updated (e.g. to None or some sort of custom NotData class).

This is done in #131 for the BulkStructure node where it works fine. Generalizing it might be a bit tricky though, as it's possible for nodes to have multiple outputs only some of which may get invalidated. Maybe the parent node class should implement an invalidation routine that by default sets all the output to None if any of the input is invalid (a reasonable base case) and the user can override this?

@liamhuber liamhuber added the feature request request partner of "enhancement" label Nov 24, 2022
@liamhuber liamhuber self-assigned this Nov 24, 2022
@liamhuber
Copy link
Member Author

I don't know the PR, but this got fixed for the DataNode class, which is the main thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request request partner of "enhancement"
Projects
None yet
Development

No branches or pull requests

1 participant