Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coarsen, rolling and weighted to generate_reductions #6703

Open
headtr1ck opened this issue Jun 18, 2022 · 1 comment
Open

Add coarsen, rolling and weighted to generate_reductions #6703

headtr1ck opened this issue Jun 18, 2022 · 1 comment

Comments

@headtr1ck
Copy link
Collaborator

headtr1ck commented Jun 18, 2022

Is your feature request related to a problem?

Coarsen reductions are currently added dynamically which is not very useful for typing.
This is a follow-up to @Illviljan in #6702 (comment)_

Same goes for Weighted.
And similar for Rolling (not sure if it is exactly the same though?)

Describe the solution you'd like

Extend the generate_reductions script to include DataArrayCoarsen and DatasetCoarsen.
Once finished: use type checking in all test_coarsen tests.

@headtr1ck
Copy link
Collaborator Author

For better docstrings (in the editor) the weighted module could be another candidate.
There only the docstrings are added dynamically, so this has a lower priority.

@headtr1ck headtr1ck changed the title Add coarsen to generate_reductions Add coarsen, rolling and weighted to generate_reductions Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant