Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automerge #6499

Closed
max-sixty opened this issue Apr 18, 2022 · 2 comments
Closed

Added automerge #6499

max-sixty opened this issue Apr 18, 2022 · 2 comments
Labels
CI Continuous Integration tools

Comments

@max-sixty
Copy link
Collaborator

What is your issue?

@pydata/xarray

Because our pipeline takes a while, it can be helpful to have an option to "merge when tests pass" — I've now set that up. So you can click here and it'll do just that.

Someone annoyingly / confusingly, the "required checks" need to be specified manually, in https://github.com/pydata/xarray/settings/branch_protection_rules/2465574 — there's no option for just "all checks".

So if we change the checks — e.g. add Python 3.11 — that list needs to be updated. If we remove a check from the our CI and don't update the list, it won't be possible to merge the PR without clicking the red "Admin Override" box — so we should keep it up to date.

image

@max-sixty max-sixty added the CI Continuous Integration tools label Apr 18, 2022
@max-sixty
Copy link
Collaborator Author

Once it's clicked it looks like:

image

@TomNicholas
Copy link
Member

Oh that's awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tools
Projects
None yet
Development

No branches or pull requests

2 participants