Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Settings does not validate if the parameter name passed is supported by the model or not. #856

Open
neilbhutada opened this issue Feb 6, 2025 · 0 comments

Comments

@neilbhutada
Copy link

When you run the following code:

model = OpenAIModel(DEPLOYMENT_NAME, openai_client=client)
agent = Agent(model)
result =  await agent.run(prompt, result_type=People, model_settings={"tempural": 45})

It should throw an error stating that tempural is not a valid parameter. However, it does not. Can we add some validation/raise an exception if the parameter in model settings is not supported. I can try solving this as well, if someone call tell me which file I should edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant