Close the file descriptor for add_attachment (#957)

* Close the file descriptor for add_attachment

If the attachment is string, the add_attachment function creates a
file descriptor then forget to close it. The patch closes the file
descriptor after the post action.

* Pass a correct type for the variable

* Convert type earliy

* Refine code format

Author: yen3

jira/client.py

@@ -35,6 +35,7 @@
     Type,
     TypeVar,
     Union,
+    cast,
     no_type_check,
 )
 from urllib.parse import urlparse
@@ -845,8 +846,11 @@ def add_attachment(
         Returns:
             Attachment
         """
+        close_attachment = False
         if isinstance(attachment, str):
             attachment: BufferedReader = open(attachment, "rb")  # type: ignore
+            attachment = cast(BufferedReader, attachment)
+            close_attachment = True
         elif isinstance(attachment, BufferedReader) and attachment.mode != "rb":
             self.log.warning(
                 "%s was not opened in 'rb' mode, attaching file may fail."
@@ -861,13 +865,17 @@ def add_attachment(
 
         if "MultipartEncoder" not in globals():
             method = "old"
-            r = self._session.post(
-                url,
-                files={"file": (fname, attachment, "application/octet-stream")},
-                headers=CaseInsensitiveDict(
-                    {"content-type": None, "X-Atlassian-Token": "no-check"}
-                ),
-            )
+            try:
+                r = self._session.post(
+                    url,
+                    files={"file": (fname, attachment, "application/octet-stream")},
+                    headers=CaseInsensitiveDict(
+                        {"content-type": None, "X-Atlassian-Token": "no-check"}
+                    ),
+                )
+            finally:
+                if close_attachment:
+                    attachment.close()
         else:
             method = "MultipartEncoder"
 
@@ -878,14 +886,21 @@ def file_stream() -> MultipartEncoder:
                 )
 
             m = file_stream()
-            r = self._session.post(
-                url,
-                data=m,
-                headers=CaseInsensitiveDict(
-                    {"content-type": m.content_type, "X-Atlassian-Token": "no-check"}
-                ),
-                retry_data=file_stream,
-            )
+            try:
+                r = self._session.post(
+                    url,
+                    data=m,
+                    headers=CaseInsensitiveDict(
+                        {
+                            "content-type": m.content_type,
+                            "X-Atlassian-Token": "no-check",
+                        }
+                    ),
+                    retry_data=file_stream,
+                )
+            finally:
+                if close_attachment:
+                    attachment.close()
 
         js: Union[Dict[str, Any], List[Dict[str, Any]]] = json_loads(r)
         if not js or not isinstance(js, Iterable):