Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make low battery indicator more visible #559

Closed
laurensvalk opened this issue Dec 21, 2021 · 2 comments
Closed

[Feature] Make low battery indicator more visible #559

laurensvalk opened this issue Dec 21, 2021 · 2 comments
Labels
enhancement New feature or request software: pybricks-code Issues with https://code.pybricks.com application

Comments

@laurensvalk
Copy link
Member

laurensvalk commented Dec 21, 2021

Is your feature request related to a problem? Please describe.

Our low-battery indicator currently looks like this:

image

But it can be easy to miss and users may not know what it means.

Describe the solution you'd like

We should keep the light, but we could also have one of the following to make it clearer:

  • Raise an appropriate exception. Perhaps an OSError or the SystemExit like we do for the button press, but with a different message.
  • Battery status in Pybricks Code (see [Feature] Next steps for Pybricks Code editor #173) or prevent program from starting.
@laurensvalk laurensvalk added enhancement New feature or request triage Issues that have not been triaged yet software: pybricks-code Issues with https://code.pybricks.com application and removed triage Issues that have not been triaged yet labels Dec 21, 2021
@laurensvalk
Copy link
Member Author

I like the exception because it does not require much change in Pybricks Code, and keeps it generic with Pybricksdev, etc.

@dlech
Copy link
Member

dlech commented Dec 21, 2021

The low battery warning just means that the battery won't last much longer, but you can still keep using your hub until it shuts itself off. If we raise an exception or prevent the user program from starting, then it effectively reduces the amount of time you can use your hub. With disposable batteries, it means you would have to throw them out even though there is still some useful life left in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request software: pybricks-code Issues with https://code.pybricks.com application
Projects
None yet
Development

No branches or pull requests

2 participants