Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: SciPy bounds are not enforced #476

Closed
BradyPlanden opened this issue Aug 27, 2024 · 1 comment · Fixed by #371
Closed

[Bug]: SciPy bounds are not enforced #476

BradyPlanden opened this issue Aug 27, 2024 · 1 comment · Fixed by #371
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

Python Version

3.12

Describe the bug

The current bounds construction for the SciPy optimisers applies the user-selected bounds, but with SciPy's keep_feasible argument defaulted to False. This results in the selected bounds not being enforced within the optimiser.

Steps to reproduce the behaviour

This can be seen here: https://github.com/pybop-team/PyBOP/blob/1eebc18f87694d787af01b345e3312e82707cdb9/examples/notebooks/ecm_trust-constr.ipynb

Relevant log output

No response
@BradyPlanden BradyPlanden added the bug Something isn't working label Aug 27, 2024
@BradyPlanden
Copy link
Member Author

Fixed in #371

@BradyPlanden BradyPlanden linked a pull request Aug 27, 2024 that will close this issue
Allow nonlinear constraints #353 #371
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow nonlinear constraints #353 MarkBlyth/PyBOP_develop
1 participant
@BradyPlanden