Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter set check not working in base_ecm.py #387

Closed
NicolaCourtier opened this issue Jul 3, 2024 · 0 comments · Fixed by #388
Closed

Parameter set check not working in base_ecm.py #387

NicolaCourtier opened this issue Jul 3, 2024 · 0 comments · Fixed by #388
Assignees
@NicolaCourtier
Labels
bug Something isn't working

Comments

@NicolaCourtier
Copy link
Member

Python Version

3.10.12

Describe the bug

PyBOP models accept parameter sets of the form pybop.ParameterSet and pybamm.ParameterValues. The OCP check in base_ecm.py needs to be updated to allow for this to resolve the errors in #371.

Steps to reproduce the behaviour

https://github.com/pybop-team/PyBOP/actions/runs/9599058153/job/26477079114?pr=371

Relevant log output

pybop/models/empirical/base_ecm.py:55: AttributeError
AttributeError: 'dict' object has no attribute 'params'
@NicolaCourtier NicolaCourtier added the bug Something isn't working label Jul 3, 2024
@NicolaCourtier NicolaCourtier self-assigned this Jul 3, 2024
@NicolaCourtier NicolaCourtier mentioned this issue Jul 3, 2024
Merged
15 tasks
@NicolaCourtier NicolaCourtier linked a pull request Jul 3, 2024 that will close this issue
Add keys to ParameterSet and update ECM OCV check #388
Merged
15 tasks
@NicolaCourtier NicolaCourtier moved this to Done in v24.9 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicolaCourtier NicolaCourtier

Labels
bug Something isn't working
Projects
v24.9
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add keys to ParameterSet and update ECM OCV check pybop-team/PyBOP
1 participant
@NicolaCourtier