Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to skip experiment steps #4839

Merged
merged 7 commits into from
Feb 14, 2025
Merged

Conversation

aabills
Copy link
Contributor

@aabills aabills commented Feb 12, 2025

Description

Adds an option to skip experiment steps. This is useful in CCCV if you start with too high of an initial SOC to run the CC step.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (8235474) to head (0712fca).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4839   +/-   ##
========================================
  Coverage    98.70%   98.70%           
========================================
  Files          303      303           
  Lines        23335    23343    +8     
========================================
+ Hits         23032    23040    +8     
  Misses         303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MarcBerliner MarcBerliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments.

@aabills aabills requested a review from MarcBerliner February 12, 2025 19:30
@aabills aabills enabled auto-merge (squash) February 12, 2025 19:32
MarcBerliner
MarcBerliner previously approved these changes Feb 12, 2025
@aabills aabills disabled auto-merge February 12, 2025 19:43
@kratman kratman marked this pull request as draft February 13, 2025 14:18
@kratman
Copy link
Contributor

kratman commented Feb 13, 2025

@aabills I made this a draft so that it was not accidentally merged while you address Valentin's comments

@aabills
Copy link
Contributor Author

aabills commented Feb 13, 2025

Thanks yeah this is going to take a bit longer because it substantially changes behavior in a few tests, so will take a bit of back and forth to get coverage.

@aabills aabills marked this pull request as ready for review February 13, 2025 19:34
@aabills aabills enabled auto-merge (squash) February 13, 2025 19:35
@aabills aabills merged commit b5863e9 into pybamm-team:develop Feb 14, 2025
26 checks passed
@kratman kratman deleted the skip-ok branch February 14, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants