-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to skip experiment steps #4839
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4839 +/- ##
========================================
Coverage 98.70% 98.70%
========================================
Files 303 303
Lines 23335 23343 +8
========================================
+ Hits 23032 23040 +8
Misses 303 303 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor comments.
@aabills I made this a draft so that it was not accidentally merged while you address Valentin's comments |
Thanks yeah this is going to take a bit longer because it substantially changes behavior in a few tests, so will take a bit of back and forth to get coverage. |
Description
Adds an option to skip experiment steps. This is useful in CCCV if you start with too high of an initial SOC to run the CC step.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commit
nox -s tests
nox -s doctests