Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error for unknown parameter sets #3063

Closed
rtimms opened this issue Jun 23, 2023 · 2 comments
Closed

Raise error for unknown parameter sets #3063

rtimms opened this issue Jun 23, 2023 · 2 comments
Assignees
@tommaull
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows

Comments

@rtimms
Copy link
Contributor

rtimms commented Jun 23, 2023

Raise an error when you do e.g. parameter_values = pybamm.ParameterValues("Junk").

Need to replace if isinstance(values, str) and values in pybamm.parameter_sets: with if isinstance(values, str) and values in pybamm.parameter_sets.keys(): here and raise an error if the name isn't found.
@rtimms rtimms added difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows labels Jun 23, 2023
@tommaull
Copy link
Contributor

tommaull commented Jul 7, 2023

please assign me!

@tommaull tommaull mentioned this issue Jul 10, 2023
Merged
8 tasks
@rtimms
Copy link
Contributor Author

rtimms commented Jul 11, 2023

Fixed by #3132

@rtimms rtimms closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommaull tommaull

Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtimms @tommaull