Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cubic interpolant for 2D data #2017

Closed
TomTranter opened this issue Apr 13, 2022 · 2 comments
Closed

Allow cubic interpolant for 2D data #2017

TomTranter opened this issue Apr 13, 2022 · 2 comments
Labels

Comments

@TomTranter
Copy link
Contributor

Description

Currently the scipy interpolate.interp2d function is called if there are 2 x arguments and y is 2d but we only allow "linear" interpolants. The function will accept "cubic" and "quintic" also. It would be useful to have these options accessible. Were they prevented for any good reason? Convergence issues maybe?

Motivation

Functions that interpolate 2 variables will be more accurately represented.

Possible Implementation

No response

Additional context

No response

@valentinsulzer
Copy link
Member

Don't think they were prevented for any particular reason, there just wasn't a good reason to have them.
We should definitely add them. But we should be wary of the fact that they don't preserve monotonicity

@rtimms
Copy link
Contributor

rtimms commented Sep 26, 2022

Fixed in #2229

@rtimms rtimms closed this as completed Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants