Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeCondition errors when a condition does not exist in statusEffects #656

Closed
bithir opened this issue May 23, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bithir
Copy link
Collaborator

bithir commented May 23, 2024

The code:
if (typeof effect === "string") effect = foundry.utils.duplicate(CONFIG.statusEffects.find((e) => e.id == effect));
Will generate an error if the effect sought is not in the list of status effects.

Suggestion: if we can't find the effect in the list of status effect, just ignore it and continue on with life. Its function is unknown and not related to the symbaroum system.

@bithir
Copy link
Collaborator Author

bithir commented May 23, 2024

This is in SymbaroumActor.removeCondition

@bithir bithir self-assigned this Jun 21, 2024
@bithir bithir added the bug Something isn't working label Jun 21, 2024
@bithir bithir added this to the 5.1.0 milestone Jun 21, 2024
bithir added a commit that referenced this issue Jul 9, 2024
@bithir bithir closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant