Ignore files in .gitignore when auto-detecting monorepo projects

[f-f]

Bug report from @thomashoneyman:

when you use NPM workspaces, the contents of each workspace member are symlinked into the node_modules directory. That means the spago.yaml file is, too. That causes Spago to auto-detect the project within node_modules and try to build it as another workspace member (in this case, shadowing my actual one).

A good solution for this would be to not look for projects in places that are gitignored.
This is where we'd need to add paths to exclude:

spago/spaghetto/src/Spago/Config.purs

Line 302 in e611cac

{ succeeded: otherConfigPaths, failed } <- liftAff $ Glob.match' Paths.cwd [ "**/spago.yaml" ] { ignore: [ ".spago", "spago.yaml" ] }

[f-f]

Fixed in 7883931

[thomashoneyman]

I'm still seeing this – for example, if you run npm install && spago build on the current registry-dev master, you'll see warnings like this:

Warning 11 of 11:

  in module Registry.Solver
  at node_modules/registry-app/src/Registry/Solver.purs:90:1 - 90:114 (line 90, column 1 - line 90, column 114)

    A custom warning occurred while solving type class constraints:

      Data.Map's `Semigroup` instance is now unbiased and differs from the left-biased instance defined in PureScript releases <= 0.13.x.


  in value declaration minimizeErrors

  See https://github.com/purescript/documentation/blob/master/errors/UserDefinedWarning.md for more information,
  or to contribute content related to this warning.

...where the link is to the node_modules directory.

[f-f]

I'm not sure we released a new version with this fix! Not at a computer right now, I can check later

[thomashoneyman]

Oh! Sorry, I thought it was present in 0.91.0 -- in that case I take it back!

[f-f]

It looks like we did publish it in 0.91.0 - so we are probably just missing some detail.
@thomashoneyman if you run with -v, the debug logging will tell you which Spago configs it auto-discovered - what do you see there?

[thomashoneyman]

Reading Spago workspace configuration...
Reading config from spago.yaml
Found packages at these paths:
  app/spago.yaml
  lib/spago.yaml
  scripts/spago.yaml
  node_modules/registry-app/spago.yaml
  node_modules/registry-lib/spago.yaml

[f-f]

Uh, I can repro this. I'll have a look..

[f-f]

(in all of this, a spago build fails with a mysterious error, so I'll debug that first)

[f-f]

Ah, symbolic links always throw a wrench in:

fatal: pathspec 'node_modules/registry-app/spago.yaml' is beyond a symbolic link

I'll cook a patch, but to use it in the registry we'll have to adjust the spago run cwd thing, as that has been fixed too

[f-f]

Fixed again in 0.91.1