Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requestAnimationFrame callback should have type Timestamp -> Effect Unit #27

Open
PanAeon opened this issue May 4, 2020 · 1 comment
Open

requestAnimationFrame callback should have type Timestamp -> Effect Unit #27

PanAeon opened this issue May 4, 2020 · 1 comment
Labels
type: breaking change A change that requires a major version bump. type: enhancement A new feature or addition.

Comments

@PanAeon
Copy link

PanAeon commented May 4, 2020

According to mdn requestAnimationFrame's callback function:

The callback function is passed one single argument, a DOMHighResTimeStamp similar to the one returned by performance.now(), indicating the point in time when requestAnimationFrame() starts to execute callback functions.
@garyb garyb added the type: enhancement A new feature or addition. label May 4, 2020
@PanAeon
Copy link
Author

PanAeon commented May 21, 2020

@garyb , I can send pull request, but I'm not sure how to correctly represent DOMHighResTimeStamp

@garyb garyb added the type: breaking change A change that requires a major version bump. label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: breaking change A change that requires a major version bump. type: enhancement A new feature or addition.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PanAeon @garyb