Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add styling for input:not([type]) #261

Closed
funkyvisions opened this issue Dec 16, 2013 · 5 comments
Closed

Add styling for input:not([type]) #261

funkyvisions opened this issue Dec 16, 2013 · 5 comments
Labels
bug

Comments

@funkyvisions
Copy link
Contributor

Currently if you create an INPUT tag without a "type", purecss does not style it. It would be nice to add "input:not([type])" to the 5 rules that style the rest of the INPUTs. Right now I have to provide my own css to do this.
@ericf
Copy link
Collaborator

ericf commented Dec 17, 2013

Makes sense. We could also use this opportunity to add code comments for why all the type attributes selectors are added instead of simply input.

@funkyvisions
Copy link
Contributor Author

Would you like me to submit a pull request and then someone that understands what code comments need to be added can do so?

@ericf
Copy link
Collaborator

ericf commented Dec 17, 2013

Sounds great, thanks!

@funkyvisions funkyvisions mentioned this issue Dec 17, 2013
Merged
@funkyvisions
Copy link
Contributor Author

Hope I did it right. This is my first pull-request for a YUI project, so hopefully I conformed :)

@ericf
Copy link
Collaborator

ericf commented Dec 18, 2013

Closing… #263 has been merged.

@ericf ericf closed this as completed Dec 18, 2013
@ericf ericf mentioned this issue Feb 6, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericf @funkyvisions