Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic tests via CSSLint #25

Closed
ericf opened this issue May 27, 2013 · 2 comments
Closed

Add basic tests via CSSLint #25

ericf opened this issue May 27, 2013 · 2 comments
Assignees
Labels
Milestone

Comments

@ericf
Copy link
Collaborator

ericf commented May 27, 2013

We should add at least some very basic tests to Pure. At a bare minimum we can use CSSLint and we might want to hook it up via the Grunt plugin.

@ghost ghost assigned ericf Jun 4, 2013
@ericf
Copy link
Collaborator Author

ericf commented Jun 5, 2013

I have something working on a local branch. The CSSLint Grunt plugin is useful but it isn't great, so for now I'm adding a separate task grunt test which will do the linting and errors (exit 2) if there's any lint warning (there's no way with the Grunt plugin to only log warns) :-/ This way running grunt doesn't lint, but grunt release will lint before it continues building and bundling the release.

The current master has several lint errors (I already fixed some of them) which I consider real problems which we should fix.

@ericf
Copy link
Collaborator Author

ericf commented Jun 5, 2013

Merged #65 which closes this.

@ericf ericf closed this as completed Jun 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant