Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exanding the fractions those who think only in columns #144

Closed
wants to merge 1 commit into from
Closed

Exanding the fractions those who think only in columns #144

wants to merge 1 commit into from

Conversation

mike-engel
Copy link

I've run into some designers coding their portfolios and other basic websites who only think in column widths. They aren't math oriented, and thus have a harder time associating reduced fractions with column widths. This shouldn't add any bloat, and will make it more usable to those who prefer column based class notation.

@tilomitra
Copy link
Contributor

This makes sense to me. @ericf, what do you think?

@ericf
Copy link
Collaborator

ericf commented Jul 23, 2013

@mike-engel Grids is based on a 24 unit grid. If these redundant fractions were to be added, shouldn't they all have a 24 denominator?

@mike-engel
Copy link
Author

@ericf I could add those in as well. I would say a majority of designers deal with a 12 column grid, however, instead of a 24 column one. It's a possibility to expand for both 12 and 24 columns.

@ericf
Copy link
Collaborator

ericf commented Jul 23, 2013

I would say a majority of designers deal with a 12 column grid, however, instead of a 24 column one. It's a possibility to expand for both 12 and 24 columns.

@mike-engel I think this shows that the current classnames which use reduced fractions are probably best, especially given that we're planning a revamp of the Grids system: #146. I think this best place for this, given the desire for customization, would be the Grid Builder. @tilomitra would you be up for implementing this feature in Grid Builder?

@tilomitra
Copy link
Contributor

@tilomitra would you be up for implementing this feature in Grid Builder?

Yeah, I can do that. We can link to it from the Grids page. I agree that we should hold off on this until the new grids gets merged in. I think that's a little easier to work with anyway.

ericf added a commit to ericf/pure that referenced this pull request Nov 24, 2013
@ericf ericf mentioned this pull request Nov 24, 2013
1 task
@ericf
Copy link
Collaborator

ericf commented Nov 24, 2013

Closing in favor of #245

@ericf ericf closed this Nov 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants