puppetlabs-firewall 5.0.0 is not compatible with stdlib 9.0.0

[corporate-gadfly]

Describe the Bug

puppetlabs-firewall 5.0.0 is not compatible with stdlib 9.0.0

Expected Behavior

Make a future version of puppetlabs-firewall compatible with stdlib 9.0.0

Steps to Reproduce

Steps to reproduce the behavior:

1. Bump stdlib to 9.0.0
2. You will receive an error:

Server Error: Evaluation Error: Error while evaluating a Function Call, deprecation. ensure_packages.
This function is deprecated, please use stdlib::ensure_packages instead.
at ["/etc/puppetlabs/code/environments/qa/modules/firewall/manifests/linux/redhat.pp", 69]:["/etc/puppetlabs/code/environments/qa/site/profiles/manifests/base.pp", 12]
(file: /etc/puppetlabs/code/environments/qa/modules/firewall/manifests/linux/redhat.pp, line: 69, column: 5) on node xxx.yyy.zzz

Environment

• Node is CentOS Stream 8
• Puppet agent 8.0.0
• Puppet server 8.0.0

[LukasAud]

This issue should have been addressed in #1135. The module is currently pending a major release.

[mphilipps]

How long is this expected to take? Puppet 8 was released in April.

[ghost]

Agree, this is one of the only mods which doesn't support it and would be good to know the timeframe for the major release

[robertc99]

I'd like to also request a release. It would be nice to starting using stdlib 9 without getting warnings.

[corporate-gadfly]

@LukasAud : I'm not a puppet expert, but regarding #1135, why rely on stdlib features only available in 9.x. How about something like the following (which will presumably work with both stdlib 8.x and 9.x)?

if $package_name {
    package { $package_name:
        ensure => $package_ensure,
    }
}

[robertc99]

that would fail with a duplicate resource error if the package is loaded elsewhere. the entire point of ensure_packages is thats its safe against redefinitiion.

[corporate-gadfly]

TY, makes sense.

[corporate-gadfly]

Closing as #1135 has been merged and was released with 6.0.0.