Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported container runtime 'openvzve' with facter 4.8.0+ #2784

Open
Viktor0014 opened this issue Dec 19, 2024 · 1 comment
Open

Unsupported container runtime 'openvzve' with facter 4.8.0+ #2784

Viktor0014 opened this issue Dec 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Viktor0014
Copy link

Describe the Bug

Since facter 4.8.0 we getting unsupported container runtime 'openzve'

Problem origin here facter source

Expected Behavior

Support 'openvzve' as runtime again

Steps to Reproduce

  1. Setup virtuozzo 7 server (any version)
  2. Install puppet-agent 7.32 or newer
  3. Simple run facter resulting in following output (stripped down)
    [[email protected] resolvers]# facter virtual
    [2024-12-19 11:11:27.557706 ] WARN Facter::Resolvers::Containers - Container runtime, '0ae2eb17-876d-46b1-a093-1ee716f7a75a', is unsupported, setting to, 'container_other'
    container_other

Environment

  • puppet-agent-7.32.0-1.el8.x86_64 or newer
  • Virtuozzo Linux release 7.9
  • Facter 4.8.0

Additional Context

see also fact for openvz in source code https://github.com/puppetlabs/facter/blob/8dfaabf794dab16267120e906002c8147a27ef8c/lib/facter/resolvers/open_vz.rb

@Viktor0014 Viktor0014 added the bug Something isn't working label Dec 19, 2024
@joshcooper
Copy link
Contributor

This is caused by 7bc38cc because if the container type is not recognized by the Container resolver, then it returns container_other

vm = 'container_other'

However, the VirtualDetector calls the Container resolver

Facter::Resolvers::Containers.resolve(:vm)

So container_other prevents it from falling back to other methods like check_open_vz

check_docker_lxc || check_freebsd || check_openbsd || check_gce || check_illumos_lx || \
retrieve_from_virt_what || check_vmware || check_open_vz || check_vserver || \

We had the same issue with Illumox, see 31d32da

The Container resolver should ignore unknown container types so that VirtualDetector can try other methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants