From 582e1dc2f6ae17e629f9b05a54ea83eed8b30f1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Romain=20Tarti=C3=A8re?= <romain@blogreen.org> Date: Wed, 22 Apr 2020 07:57:51 -1000 Subject: [PATCH] (FACT-2564) Move zpool feature flags in a let statement --- spec/facter/resolvers/solaris/zpool_resolver_spec.rb | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/spec/facter/resolvers/solaris/zpool_resolver_spec.rb b/spec/facter/resolvers/solaris/zpool_resolver_spec.rb index 61b3cd435..54377cc18 100644 --- a/spec/facter/resolvers/solaris/zpool_resolver_spec.rb +++ b/spec/facter/resolvers/solaris/zpool_resolver_spec.rb @@ -31,6 +31,11 @@ context 'when zpool has featureflags' do let(:output) { load_fixture('zpool-with-featureflags').read } + let(:zpool_featureflags) do + 'async_destroy,empty_bpobj,lz4_compress,multi_vdev_crash_dump,spacemap_histogram,enabled_txg,' \ + 'hole_birth,extensible_dataset,embedded_data,bookmarks,filesystem_limits,large_blocks,large_dnode,' \ + 'sha512,skein,device_removal,obsolete_counts,zpool_checkpoint,spacemap_v2' + end it 'returns zpool version fact' do result = Facter::Resolvers::Solaris::ZPool.resolve(:zpool_version) @@ -39,10 +44,7 @@ it 'returns zpool featureflags fact' do result = Facter::Resolvers::Solaris::ZPool.resolve(:zpool_featureflags) - expect(result).to eq('async_destroy,empty_bpobj,lz4_compress,multi_vdev_crash_dump,' \ - 'spacemap_histogram,enabled_txg,hole_birth,extensible_dataset,embedded_data,bookmarks,' \ - 'filesystem_limits,large_blocks,large_dnode,sha512,skein,device_removal,obsolete_counts,' \ - 'zpool_checkpoint,spacemap_v2') + expect(result).to eq(zpool_featureflags) end end end