Merge pull request #3305 from mcarrolle/ssh-transport

allow ssh transport protocol for a git module spec

Author: donoghuc

lib/bolt/module_installer/specs/git_spec.rb

@@ -45,7 +45,7 @@ def initialize(init_hash, config = {})
 
           unless valid_url?(@git)
             raise Bolt::ValidationError,
-                  "Invalid URI #{@git}. Valid URIs must begin with 'git@', 'http://', or 'https://'."
+                  "Invalid URI #{@git}. Valid URIs must begin with 'git@', 'http://', 'https://' or 'ssh://'."
           end
         end
 
@@ -140,7 +140,7 @@ def sha
           return true if url.start_with?('git@')
 
           uri = URI.parse(url)
-          uri.is_a?(URI::HTTP) && uri.host
+          (uri.is_a?(URI::HTTP) || uri.scheme == "ssh") && uri.host
         rescue URI::InvalidURIError
           false
         end

spec/unit/module_installer/specs/git_spec_spec.rb

@@ -61,6 +61,11 @@
         /Option 'resolve'.*must be a Boolean/
       )
     end
+
+    it 'allow ssh URI' do
+      init_hash['git'] = 'ssh://[email protected]:12345/puppetlabs/puppetlabs-yaml'
+      expect { spec }.not_to raise_error
+    end
   end
 
   context '#to_hash' do