Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace docker image repository is hard coded #848

Open
project0 opened this issue Feb 26, 2025 · 0 comments
Open

Workspace docker image repository is hard coded #848

project0 opened this issue Feb 26, 2025 · 0 comments
Labels
kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team

Comments

@project0
Copy link

What happened?

I have configured the pulumi operator to use a different image (using ECR pull through cache) than the docker hub hosted default.

However, it seem the image name (and version) used in the workspace is hard coded.
Only way to change it to patch it via the workspace template. It does not seem a reliable way to me as one has to track changes in the operator during updates if there is a behavioral change how the workspace template is conducted.

I can see multiple solutions:

  • the image is derived based on the running/deployed manifests (difficult to reflect)
  • a configuration parameter in the operator itself
  • the workspace spec allows setting the bootstrap and fetch image with something like "operatorImage" property (we have already image, but its serves a different purpose). I am aware of the named workspace template Named workspace templates #797, but it would not solve the problem as describe initially.

Example

the final pod

apiVersion: v1
kind: Pod
spec:
  containers:
    ...
    # workspace image
    image: <id>.dkr.ecr.eu-central-1.amazonaws.com/cache/public.ecr.aws/pulumi/pulumi-go:3.147.0
    imagePullPolicy: IfNotPresent
    name: pulumi
  ...
  initContainers:
  - image: pulumi/pulumi-kubernetes-operator:v2.0.0
    name: bootstrap
    ...
  - image: pulumi/pulumi-kubernetes-operator:v2.0.0
    name: fetch
   ...

stack with workspace template:

apiVersion: pulumi.com/v1
kind: Stack
spec:
 
  workspaceTemplate:
    spec:
      image: <id>.dkr.ecr.eu-central-1.amazonaws.com/cache/public.ecr.aws/pulumi/pulumi-go:3.147.0

Output of pulumi about

not relevant

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@project0 project0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team
Projects
None yet
Development

No branches or pull requests

1 participant