Added lastUpdate state update to ensure that synchronized commits dis…

…play a succeeded status
pulumi · Mar 28, 2023 · 8fb3793 · 8fb3793
1 parent ebbf9cb
commit 8fb3793
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,8 @@ CHANGELOG
   image of the same version, fixing [issue
   #411](https://github.com/pulumi/pulumi-kubernetes-operator/issues/411)
   [#422](https://github.com/pulumi/pulumi-kubernetes-operator/pull/422)
+- Added lastUpdate state update to ensure that synchronized commits display a succeeded status.
+  [#429](https://github.com/pulumi/pulumi-kubernetes-operator/pull/429)
 
 ## 1.11.1 (2023-02-08)
 

diff --git a/pkg/controller/stack/stack_controller.go b/pkg/controller/stack/stack_controller.go
@@ -628,6 +628,11 @@ func (r *ReconcileStack) Reconcile(ctx context.Context, request reconcile.Reques
 				reqLogger.Info("Commit hash unchanged. Will poll again.", "pollFrequencySeconds", resyncFreqSeconds)
 				// Reconcile every resyncFreqSeconds to check for new commits to the branch.
 				instance.Status.MarkReadyCondition() // FIXME: should this reflect the previous update state?
+				// Ensure lastUpdate state is updated if previous sync failure occurred
+				if instance.Status.LastUpdate.State != shared.SucceededStackStateMessage {
+					instance.Status.LastUpdate.State = shared.SucceededStackStateMessage
+					instance.Status.LastUpdate.LastResyncTime = metav1.Now()
+				}
 				return reconcile.Result{RequeueAfter: time.Duration(resyncFreqSeconds) * time.Second}, nil
 			}
 
@@ -644,6 +649,11 @@ func (r *ReconcileStack) Reconcile(ctx context.Context, request reconcile.Reques
 				reqLogger.Info("Commit hash unchanged. Will poll again.", "pollFrequencySeconds", resyncFreqSeconds)
 				// Reconcile every resyncFreqSeconds to check for new commits to the branch.
 				instance.Status.MarkReadyCondition() // FIXME: should this reflect the previous update state?
+				// Ensure lastUpdate state is updated if previous sync failure occurred
+				if instance.Status.LastUpdate.State != shared.SucceededStackStateMessage {
+					instance.Status.LastUpdate.State = shared.SucceededStackStateMessage
+					instance.Status.LastUpdate.LastResyncTime = metav1.Now()
+				}
 				return reconcile.Result{RequeueAfter: time.Duration(resyncFreqSeconds) * time.Second}, nil
 			}
 
@@ -659,6 +669,11 @@ func (r *ReconcileStack) Reconcile(ctx context.Context, request reconcile.Reques
 				reqLogger.Info("Commit hash unchanged. Will poll again.", "pollFrequencySeconds", resyncFreqSeconds)
 				// Reconcile every resyncFreqSeconds to check for new commits to the branch.
 				instance.Status.MarkReadyCondition() // FIXME: should this reflect the previous update state?
+				// Ensure lastUpdate state is updated if previous sync failure occurred
+				if instance.Status.LastUpdate.State != shared.SucceededStackStateMessage {
+					instance.Status.LastUpdate.State = shared.SucceededStackStateMessage
+					instance.Status.LastUpdate.LastResyncTime = metav1.Now()
+				}
 				return reconcile.Result{RequeueAfter: time.Duration(resyncFreqSeconds) * time.Second}, nil
 			}