Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

add new layoutz to registry #2977

Merged
merged 20 commits into from
Jun 6, 2023
Merged

add new layoutz to registry #2977

merged 20 commits into from
Jun 6, 2023

Conversation

susanev
Copy link
Contributor

@susanev susanev commented Jun 3, 2023 •
edited
Loading

➡️ important: files changed is a lie nothing in static/registry/packages/navs or the package content in content will be merged, its only there to get data for the preview ⬅️

the preview has all api navs, but no resource links work

Description

this needs to ship at the same time as pulumi/registry#2606
fixes pulumi/docs#8988

questions

  • should we change the registry breadcrumb to "All packages"?

things id like to follow-up with instead of including now
pulumi/docs#9160

todo

  • need to add js to turn the package card white on smaller screens when opened
  • fix missing warning on in registry
  • add back in special registry thingz for breacrumbs
  • remove padding between main content and table of contents
  • pulumi registry -> packages
  • add breadcrumbs to landing pages
  • arrow, all packages link issue
  • fix up heading colors in navs

pls only blocking items in review, otherwise add it to the docs papercutz issue, thank you thank you!

Checklist:

  • I have reviewed the style guide.
  • If blogging, I have reviewed the blogging guide.
  • I have manually confirmed that all new links work.
  • I added aliases (i.e., redirects) for all filename changes.
  • If making css changes, I rebuilt the bundle.

@susanev susanev self-assigned this Jun 3, 2023
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@susanev susanev changed the title style fixes for registry layoutz add new layoutz to registry Jun 5, 2023
@susanev susanev mentioned this pull request Jun 5, 2023
Merged
14 tasks
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@susanev susanev requested review from sean1588 and anita-trimbur June 5, 2023 02:05
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@pulumi-bot
Copy link
Collaborator

Your site preview for commit ca61161 is ready! 🎉

http://pulumi-hugo-origin-pr-2977-ca61161e.s3-website.us-west-2.amazonaws.com.

sean1588
sean1588 approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@sean1588 sean1588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment on the edit link, but this looks great. Thanks so much for coding so cleanly.

themes/default/layouts/partials/docs/table-of-contents.html
class="text-gray-600 hover:text-gray-700 text-xs"
href="{{ $.Site.Params.contentRepositoryURL }}/issues/new?body=File: [{{ getenv "REPO_THEME_PATH" }}content/{{ .Path }}]({{ $.Page.Permalink }})"
href="{{ $.Site.Params.contentRepositoryURL }}/edit/{{ $.Site.Params.contentRepositoryBaseBranch }}/{{ getenv "REPO_THEME_PATH" }}content/{{ .Path }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link looks like it opens the code editor in github in the browser with the changes are against master by default in edit mode. the user will need to make their own branch and PR, so not sure if this may end up being confusing.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sean1588 this new flow in github, when you select that commit button, it goes through a flow of creating a branch; or it should; happy to change this though, its just what was already in use

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind doing a follow on pr though if its an issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh ok, never knew it did that when you select the commit button. that sounds good then! thanks!

susanev added 4 commits June 5, 2023 18:44
@susanev
remove bottom margin
f9aef1d 
Signed-off-by: susanev <[email protected]>
@susanev
stuff
0c9dd97 
Signed-off-by: susanev <[email protected]>
@susanev
progress
1cbe177 
Signed-off-by: susanev <[email protected]>
@susanev
fixes
4c13867 
Signed-off-by: susanev <[email protected]>
susanev added 15 commits June 5, 2023 18:44
@susanev
fix card styles
3cd1df2 
Signed-off-by: susanev <[email protected]>
@susanev
more
5dfefe7 
Signed-off-by: susanev <[email protected]>
@susanev
update
adfe355 
Signed-off-by: susanev <[email protected]>
@susanev
add styles for featured packages
710ad3d 
Signed-off-by: susanev <[email protected]>
@susanev
add styles for package list nav
a0949b7 
Signed-off-by: susanev <[email protected]>
@susanev
fixes
a16a686 
Signed-off-by: susanev <[email protected]>
@susanev
styles
07a4e42 
Signed-off-by: susanev <[email protected]>
@susanev
stylez
a3e936c 
Signed-off-by: susanev <[email protected]>
@susanev
add styles
776d88f 
Signed-off-by: susanev <[email protected]>
@susanev
styles for package card accordion
e33dee0 
Signed-off-by: susanev <[email protected]>
@susanev
empty
0433df1 
Signed-off-by: susanev <[email protected]>
@susanev
add registry data
6962d68 
Signed-off-by: susanev <[email protected]>
@susanev
lol format json
ccd4774 
Signed-off-by: susanev <[email protected]>
@susanev
stylez
6f3ac6f 
Signed-off-by: susanev <[email protected]>
@susanev
add js
e222a13 
Signed-off-by: susanev <[email protected]>
@susanev susanev force-pushed the se/fix-up-styles-for-registry branch from 18c2b4a to e222a13 Compare June 6, 2023 01:46
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@susanev
remove data
de62a6a 
Signed-off-by: susanev <[email protected]>
@pulumi-bot
Copy link
Collaborator

Your site preview for commit de62a6a is ready! 🎉

http://pulumi-hugo-origin-pr-2977-de62a6a1.s3-website.us-west-2.amazonaws.com.

@susanev susanev merged commit 2ef5205 into master Jun 6, 2023
@susanev susanev deleted the se/fix-up-styles-for-registry branch June 6, 2023 02:06
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Site previews for this pull request have been removed. ✨

gthuang added a commit that referenced this pull request Jun 13, 2023
@gthuang @mnlumi
@susanev @shughes26 @MitchellGerdisch @sean1588 @jaxxstorm @cnunciato @anita-trimbur
Update pricing page (#3049)
d20a729 
* Add clarity around AWS classic vs native

* Adjust AWS classic reference

* add redirects for get started guides (#2984)

* Update go.mod

* new code font! (#2976)

* make keynote 40 minutes, shift all other times up by 20 minutes (#2985)

* create startup offer page (#2971)

* create startup offer page

* feedback updates: fix customer logos, adjust sizing, text changes

* update styles for left side text

* update copy

* add new layoutz to registry (#2977)

* Update go.mod

* update some registry links (#2974)

* Update go.mod

* fix resource h1 sizes (#2986)

* Update go.mod

* fix scheduling mistake (#2987)

* fix scheduling mistake

* add break to schedule

* Update go.mod

* fix (#2992)

* Update go.mod

* make blank whitepapers page fancy (#2993)

* Add a sidebar link to open issues in pulumi-ai repository (#2991)

* Add a note re Github Org member vis for PR preview (#2990)

* edit this page - links (#2995)

* Update go.mod

* fix text for line wrapping handler (#2999)

* Update go.mod

* pass at updating inputs/outputs doc (#2996)

* Update lifting section (#3000)

* Revert "pass at updating inputs/outputs doc (#2996)" (#3002)

This reverts commit ef67491.

* add redirect for /pugs (#3006)

* call the get started thing a tutorial (#3005)

* change code styles to dark (#2846)

* Update _index.md (#3008)

* Update go.mod

* fix up copy buttons (#3013)

* Update go.mod

* remove url route from footer (#3017)

* Update go.mod

* add zitadel logo (#3016)

* block edit links on some pages (#3015)

* add meta imgs for docs (#3018)

* Update go.mod

* Sarah/pulumiup workshops (#3007)

* add more workshops to pulumiup thank you page

* add workshops to PulumiUP landing page

* Add blog meta image (#3020)

* quickstart experience (#2983)

* fix code blocks in notes (#3019)

* Update go.mod

* add property search

---------

Co-authored-by: Monica <[email protected]>
Co-authored-by: susan evans <[email protected]>
Co-authored-by: susanev <[email protected]>
Co-authored-by: Sarah Hughes <[email protected]>
Co-authored-by: Monica <[email protected]>
Co-authored-by: mnlumi <[email protected]>
Co-authored-by: shughes26 <[email protected]>
Co-authored-by: Alex Qiu <[email protected]>
Co-authored-by: Mitch Gerdisch <[email protected]>
Co-authored-by: Sean Holung <[email protected]>
Co-authored-by: sean1588 <[email protected]>
Co-authored-by: Lee Briggs <[email protected]>
Co-authored-by: Christian Nunciato <[email protected]>
Co-authored-by: Anita Trimbur <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sean1588 sean1588 sean1588 approved these changes

@anita-trimbur anita-trimbur anita-trimbur approved these changes

Assignees

@susanev susanev

Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Docs page layouts
4 participants
@susanev @pulumi-bot @sean1588 @anita-trimbur