Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

new code font! #2976

Merged
merged 4 commits into from
Jun 5, 2023
Merged

new code font! #2976

merged 4 commits into from
Jun 5, 2023

Conversation

susanev
Copy link
Contributor

@susanev susanev commented Jun 3, 2023 •
edited
Loading

Description

@anita-trimbur take a look at the preview and let me know what you think
also happy to try other versions of this font, or any of the other fonts

fixes #2960

Checklist:

  • I have reviewed the style guide.
  • If blogging, I have reviewed the blogging guide.
  • I have manually confirmed that all new links work.
  • I added aliases (i.e., redirects) for all filename changes.
  • If making css changes, I rebuilt the bundle.

@susanev
code font exploration
f21739f 
Signed-off-by: susanev <[email protected]>
@susanev susanev requested a review from anita-trimbur June 3, 2023 05:20
@susanev susanev self-assigned this Jun 3, 2023
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@susanev susanev requested a review from sean1588 June 3, 2023 05:24
@susanev
fix
264e305 
Signed-off-by: susanev <[email protected]>
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@anita-trimbur
Copy link
Contributor

i really like it! what do you think? do you like the slab, or would you want to see it without?

@susanev
Copy link
Contributor Author

susanev commented Jun 5, 2023

@anita-trimbur cool, lets ship it!

@lukehoban
Copy link
Contributor

The code font chosen here uses ligatures. I’m fairly strongly against that by default. For reasons similar to those articulated here: https://practicaltypography.com/ligatures-in-programming-fonts-hell-no.html.

@anita-trimbur
Copy link
Contributor

we can change from the term variant to the fixed variant to omit ligatures

@susanev
Copy link
Contributor Author

susanev commented Jun 5, 2023

lol down with ligatures, yah ill remove them later today.

@susanev
update font
77a3ff5 
Signed-off-by: susanev <[email protected]>
@pulumi-bot

This comment was marked as outdated.

Sign in to view
@susanev
Copy link
Contributor Author

susanev commented Jun 5, 2023

@anita-trimbur this is updated, take another look, let me know what you think

anita-trimbur
anita-trimbur approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@anita-trimbur anita-trimbur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still really like this! but am totally willing to defer if sean thinks otherwise. i've actually been mistakenly using iosevka without the slab in figma, and i think that's a fine alternative if anyone is more inclined.

@sean1588
Copy link
Member

sean1588 commented Jun 5, 2023

I am fairly neutral on this font change as this is quite a subjective area when it comes to the aesthetics of things.

I think aesthetically it looks nice, however I do think something feels a bit off about it though if I am being completely honest, but not sure what it is. I think it may be because I am not used to reading code in this font since it is not a font I am used to seeing in either my terminal or my code editor so that may be why it has a bit of an awkward feel me. I could be an anomaly though and maybe I just need to get used to seeing it so I'm willing to defer to what you all think.

@susanev
Copy link
Contributor Author

susanev commented Jun 5, 2023

@sean1588 @anita-trimbur kk let me try dropping the slab

@susanev
drop slab
5a12d57 
Signed-off-by: susanev <[email protected]>
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 5a12d57 is ready! 🎉

http://pulumi-hugo-origin-pr-2976-5a12d57d.s3-website.us-west-2.amazonaws.com.

@susanev susanev changed the title code font exploration new code font! Jun 5, 2023
@susanev susanev merged commit 17f8f72 into master Jun 5, 2023
@susanev susanev deleted the se/update-code-font branch June 5, 2023 22:48
gthuang added a commit that referenced this pull request Jun 13, 2023
@gthuang @mnlumi
@susanev @shughes26 @MitchellGerdisch @sean1588 @jaxxstorm @cnunciato @anita-trimbur
Update pricing page (#3049)
d20a729 
* Add clarity around AWS classic vs native

* Adjust AWS classic reference

* add redirects for get started guides (#2984)

* Update go.mod

* new code font! (#2976)

* make keynote 40 minutes, shift all other times up by 20 minutes (#2985)

* create startup offer page (#2971)

* create startup offer page

* feedback updates: fix customer logos, adjust sizing, text changes

* update styles for left side text

* update copy

* add new layoutz to registry (#2977)

* Update go.mod

* update some registry links (#2974)

* Update go.mod

* fix resource h1 sizes (#2986)

* Update go.mod

* fix scheduling mistake (#2987)

* fix scheduling mistake

* add break to schedule

* Update go.mod

* fix (#2992)

* Update go.mod

* make blank whitepapers page fancy (#2993)

* Add a sidebar link to open issues in pulumi-ai repository (#2991)

* Add a note re Github Org member vis for PR preview (#2990)

* edit this page - links (#2995)

* Update go.mod

* fix text for line wrapping handler (#2999)

* Update go.mod

* pass at updating inputs/outputs doc (#2996)

* Update lifting section (#3000)

* Revert "pass at updating inputs/outputs doc (#2996)" (#3002)

This reverts commit ef67491.

* add redirect for /pugs (#3006)

* call the get started thing a tutorial (#3005)

* change code styles to dark (#2846)

* Update _index.md (#3008)

* Update go.mod

* fix up copy buttons (#3013)

* Update go.mod

* remove url route from footer (#3017)

* Update go.mod

* add zitadel logo (#3016)

* block edit links on some pages (#3015)

* add meta imgs for docs (#3018)

* Update go.mod

* Sarah/pulumiup workshops (#3007)

* add more workshops to pulumiup thank you page

* add workshops to PulumiUP landing page

* Add blog meta image (#3020)

* quickstart experience (#2983)

* fix code blocks in notes (#3019)

* Update go.mod

* add property search

---------

Co-authored-by: Monica <[email protected]>
Co-authored-by: susan evans <[email protected]>
Co-authored-by: susanev <[email protected]>
Co-authored-by: Sarah Hughes <[email protected]>
Co-authored-by: Monica <[email protected]>
Co-authored-by: mnlumi <[email protected]>
Co-authored-by: shughes26 <[email protected]>
Co-authored-by: Alex Qiu <[email protected]>
Co-authored-by: Mitch Gerdisch <[email protected]>
Co-authored-by: Sean Holung <[email protected]>
Co-authored-by: sean1588 <[email protected]>
Co-authored-by: Lee Briggs <[email protected]>
Co-authored-by: Christian Nunciato <[email protected]>
Co-authored-by: Anita Trimbur <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anita-trimbur anita-trimbur anita-trimbur approved these changes

@sean1588 sean1588 Awaiting requested review from sean1588

Assignees

@susanev susanev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected inconsistent font style on environmental variables page
5 participants
@susanev @pulumi-bot @anita-trimbur @lukehoban @sean1588