Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundanzen in Button Styles entfernen #7419

Open
sdvg opened this issue Feb 26, 2025 · 0 comments
Open

Redundanzen in Button Styles entfernen #7419

sdvg opened this issue Feb 26, 2025 · 0 comments
Labels
refactoring

Comments

@sdvg
Copy link
Member

sdvg commented Feb 26, 2025 •
edited
Loading

Wir haben für Button-Styles Mixins definiert, da diese an mehreren Stellen benötigt werden (Button, LinkButton. PopoverButton SplitButton, ggf. weitere).

Trotzdem werden einzelne Styles außerhalb des Mixins definiert und in jede Komponente kopiert. Diese Styles sollten in die Mixins verschoben werden.

Betroffen sind alle Themes.

Beispiel:

https://github.com/public-ui/kolibri/blob/develop/packages/themes/default/src/components/button.scss#L9-L14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
KoliBri Board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sdvg