Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When serving JSON responses, file-too-large should be JSON #135

Closed
HalosGhost opened this issue Oct 30, 2015 · 1 comment
Closed

When serving JSON responses, file-too-large should be JSON #135

HalosGhost opened this issue Oct 30, 2015 · 1 comment
Labels
deployment wontfix

Comments

@HalosGhost
Copy link
Contributor

At the moment, the following is served when a file that is too large is attempted to be uploaded (even if the client specifies to receive JSON):

<html>
<head><title>413 Request Entity Too Large</title></head>
<body bgcolor="white">
<center><h1>413 Request Entity Too Large</h1></center>
<hr><center>nginx</center>
</body>
</html>

As with #134, the issue with this is that the user cannot actually rely on receiving valid JSON which makes the API less predictable and consistent.
@HalosGhost HalosGhost mentioned this issue Oct 30, 2015
Closed
@buhman
Copy link
Member

buhman commented Oct 30, 2015

That response, as indicated there and in the headers, is from Nginx, not pb.

This can't be fixed without either replacing/modifying nginx, or removing that particular limitation, neither of which are attractive ideas.

@buhman buhman closed this as completed Oct 30, 2015
@buhman buhman mentioned this issue Oct 30, 2015
Open
@buhman buhman mentioned this issue Jan 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deployment wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HalosGhost @buhman