Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance mode does not work #2705

Closed
OpenSource03 opened this issue Nov 13, 2020 · 3 comments · Fixed by #4421
Closed

Maintenance mode does not work #2705

OpenSource03 opened this issue Nov 13, 2020 · 3 comments · Fixed by #4421
Labels
bug Something that's not working as it's intended to be.

Comments

@OpenSource03
Copy link

Background (please complete the following information):

  • Panel or Daemon: panel
  • Version of Panel/Daemon: 1.1.1
  • Server's OS: Debian 9
  • Your Computer's OS & Browser: macOS, Safari

Describe the bug
I'm not sure if you're aware of this, but Maintenance mode does not work.

To Reproduce
After trying to enable it, and hitting the save button, it automatically disables after the page refresh.

Expected behavior
The Maintenance mode should enable and not let any users enter their server panel if they are on the node with mm enabled.

@GravityCube
Copy link
Contributor

GravityCube commented Nov 13, 2020

It does enable it. It seems to take a few seconds and F5 to see that it was enabled (The admin dashboard is not using React). Regardless of that it doesn't have the effect that is suppose to have. The clients can still access their servers.

@GravityCube
Copy link
Contributor

GravityCube commented Nov 13, 2020

It seems that the maintenance mode is not implemented. I couldn't find anything related on wings and the Node model doesn't take maintenance into account so it is never sent to wings.

panel/app/Models/Node.php

Lines 149 to 175 in c928214

public function getConfiguration()
{
return [
'debug' => false,
'uuid' => $this->uuid,
'token_id' => $this->daemon_token_id,
'token' => Container::getInstance()->make(Encrypter::class)->decrypt($this->daemon_token),
'api' => [
'host' => '0.0.0.0',
'port' => $this->daemonListen,
'ssl' => [
'enabled' => (! $this->behind_proxy && $this->scheme === 'https'),
'cert' => '/etc/letsencrypt/live/' . $this->fqdn . '/fullchain.pem',
'key' => '/etc/letsencrypt/live/' . $this->fqdn . '/privkey.pem',
],
'upload_limit' => $this->upload_size,
],
'system' => [
'data' => $this->daemonBase,
'sftp' => [
'bind_port' => $this->daemonSFTP,
],
],
'allowed_mounts' => $this->mounts->pluck('source')->toArray(),
'remote' => route('index'),
];
}

@notAreYouScared
Copy link
Contributor

Its not exported in the configuration. Never was exported in 0.7 either but its there

@DaneEveritt DaneEveritt added the bug Something that's not working as it's intended to be. label Nov 29, 2020
@matthewpi matthewpi moved this to 🆕 New in Backlog Nov 2, 2022
@matthewpi matthewpi added this to Backlog Nov 2, 2022
@matthewpi matthewpi moved this from 🆕 New to 🔖 Awaiting merge in Backlog Nov 6, 2022
@matthewpi matthewpi moved this from 🔖 Awaiting merge to 🧨 Awaiting release in Backlog Nov 15, 2022
@matthewpi matthewpi moved this from 🧨 Awaiting release to 🎉 Released in Backlog Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that's not working as it's intended to be.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants