Fix deadlock when canceling the slicing while gcode is creating thumbnails #6476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bubnikv
added a commit
that referenced
this pull request
May 4, 2021
…onously from the background slicing thread, that supports cancellation. The generic mechanism is used for generating thumbnails into G-code and Fixes Fix deadlock when canceling the slicing while gcode is creating thumbnails #6476 Thanks @supermerill for pointing out the issue.
|
Thanks for pointing out the issue. Fixed with 1aef86f in a generic way, supporting immediate cancellation. |
supermerill
pushed a commit
to supermerill/SuperSlicer
that referenced
this pull request
Jun 3, 2021
…onously from the background slicing thread, that supports cancellation. The generic mechanism is used for generating thumbnails into G-code and Fixes Fix deadlock when canceling the slicing while gcode is creating thumbnails prusa3d#6476 Thanks @supermerill for pointing out the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating thumbnail, it push a process on the gui thread and wait for it to finish.
But when cancelling, the gui thread switch the cancel flag and lock again (waiting for exception?)
So if we cancel just before the creation of thumbnails, then there is a deadlock.
Here is an extensive and complicated way to solve that problem.
The minimum is to throw_if_canceled(); just before sending & waiting for the thumbnail creation, that way the chance of this use occurring should be very small.