Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private-vars-leading-underscore on internal functions in libraries is not a best practice #523

Closed
ZumZoom opened this issue Nov 16, 2023 · 2 comments

Comments

@ZumZoom
Copy link

ZumZoom commented Nov 16, 2023

In #511 a change was made to treat library internal functions the same way they are treated in contracts. Almost all of the solidity libraries are not using underscore for internal functions naming. Even in the official docs they don't use underscores on internal functions in libraries https://docs.soliditylang.org/en/latest/contracts.html#libraries.

@dbale-altoros
Copy link
Collaborator

@ZumZoom good catch
we will review this
thanks for the input!

@dbale-altoros
Copy link
Collaborator

Corrected here
#525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants