Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unable to satisfy indentation rules for functions with multiple return values #49

Closed
chrisaxiom opened this issue Jul 30, 2018 · 4 comments · Fixed by #50
Closed
Labels

Comments

@chrisaxiom
Copy link

I have a particular line in our contract that is unable to pass the linters indentation rules:

(bytes32 r, bytes32 s, uint8 v) = SomeLibrary.splitSignature(signature);

Error:

Expected indentation of 12 spaces, but found 13 [indent]

If you remove a space from before the first bracket, it replaces 13 with 11 in the error message. Seems to be an issue with any function that has multiple return values.

@fvictorio
Copy link
Contributor

Thanks @chrisaxiom, this looks like a bug indeed. I think declaring variables in a tuple assignment is a feature of the last solidity version, so maybe we don't have tests for that yet.

@clemlak
Copy link

clemlak commented Sep 18, 2018

The bug is still present, is there any planned update soon?

@fvictorio
Copy link
Contributor

There is an open PR. It had some comments last time I checked, but I'll try to make those changes and merge it.

@fvictorio
Copy link
Contributor

@chrisaxiom @clemlak This should be fixed in 1.3.0. Please re-open if it persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants